Truncate wide cells in the interactive table browser#6034
Draft
tanishgupta-db wants to merge 1 commit into
Draft
Truncate wide cells in the interactive table browser#6034tanishgupta-db wants to merge 1 commit into
tanishgupta-db wants to merge 1 commit into
Conversation
Contributor
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Truncates each cell to a fixed width (with an ellipsis) in the interactive table browser
(
libs/tableview). Previously a single very large value — for example a big BLOB — made its columnextremely wide and degraded rendering and horizontal scrolling.
This affects all consumers of the interactive browser:
experimental aitools tools query,experimental postgres query, and the experimental preview-datasets command. Normal values stillshow in full; only unusually long cells are shortened.
Why
The browser sized columns to the full length of the widest value with no upper bound, so one
oversized cell could make the table unusable. Bounding each cell keeps the layout stable regardless
of the data.
Tests
the rendered table lines with an oversized cell.
libs/tableview, aitools, and postgres tests still pass.