AIR CLI: always upload requirements.yaml on the run submit path#6031
Open
riddhibhagwat-db wants to merge 1 commit into
Open
AIR CLI: always upload requirements.yaml on the run submit path#6031riddhibhagwat-db wants to merge 1 commit into
riddhibhagwat-db wants to merge 1 commit into
Conversation
The AI Runtime launcher reads <func_dir>/requirements.yaml for every run. The Go CLI only uploaded it when a requirements file or inline dependencies were declared, so a run with no dependencies (e.g. a plain command) shipped no requirements.yaml and failed at launch with RUN_EXECUTION_ERROR. Jobs then retried, and the retries surfaced an unrelated PrincipalContext propagation error, masking the real cause. Always upload requirements.yaml: the declared file, a synthesized doc from inline dependencies, or an empty doc when neither is set. This matches the Python CLI, which synthesizes an empty requirements.yaml for the AI Runtime path. Co-authored-by: Isaac
Contributor
Waiting for approvalCould not determine reviewers from git history. Eligible reviewers: Suggestions based on git history. See OWNERS for ownership rules. |
Collaborator
Integration test reportCommit: 7525d79
8 interesting tests: 4 SKIP, 3 KNOWN, 1 RECOVERED
Top 6 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes & Why
The AI Runtime launcher reads <func_dir>/requirements.yaml for every run. The Go CLI only uploaded it when a requirements file or inline dependencies were declared, so a run with no dependencies (e.g. a plain command) shipped no requirements.yaml and failed at launch with RUN_EXECUTION_ERROR. Jobs then retried, and the retries surfaced an unrelated PrincipalContext propagation error, masking the real cause.
Always upload requirements.yaml: the declared file, a synthesized doc from inline dependencies, or an empty doc when neither is set. This matches the Python CLI, which synthesizes an empty requirements.yaml for the AI Runtime path.
Tests
experimental/air/cmd/runupload_test.gofor each of the three branches as described above