Skip to content

Prepare for upstream changes to tagging.py#6029

Open
janniklasrose wants to merge 5 commits into
mainfrom
janniklasrose/nextchanges-prep-for-upstream-changes
Open

Prepare for upstream changes to tagging.py#6029
janniklasrose wants to merge 5 commits into
mainfrom
janniklasrose/nextchanges-prep-for-upstream-changes

Conversation

@janniklasrose

@janniklasrose janniklasrose commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Changes

Tagging logic currently in release_tagging.py is being upstreamed. This includes README.md inside a fragment being treated as a normal fragment and reading the sections from .codegen.json.

Once upstream changes land, they will make their way into CLI via the next run of genkit. We will then be able to drop release_tagging.py and change tagging.yml rewrite to point back at tagging.py.

Why

Align with upcoming upstream changes.

Tests

Locally

@janniklasrose
janniklasrose marked this pull request as ready for review July 22, 2026 16:28
@janniklasrose
janniklasrose requested a review from pietern July 22, 2026 16:28
@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: f798342

Run: 29938188636

Env 🟨​KNOWN 🔄​flaky 💚​RECOVERED 🙈​SKIP ✅​pass 🙈​skip Time
💚​ aws linux 4 4 314 1057 7:26
💚​ aws windows 4 4 316 1055 7:38
🔄​ azure linux 2 4 4 312 1056 7:52
💚​ azure windows 4 4 316 1054 5:23
🟨​ gcp linux 3 1 4 313 1058 10:28
🟨​ gcp windows 3 1 4 315 1056 9:09
10 interesting tests: 4 SKIP, 3 KNOWN, 2 flaky, 1 RECOVERED
Test Name aws linux aws windows azure linux azure windows gcp linux gcp windows
💚​ TestAccept 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
🙈​ TestAccept/bundle/invariant/no_drift 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🙈​ TestAccept/bundle/resources/vector_search_endpoints/drift/recreated_same_name 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🙈​ TestAccept/bundle/resources/vector_search_indexes/recreate/embedding_dimension 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🙈​ TestAccept/ssh/connection 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🔄​ TestFsCpSourceIsDirectoryButTargetIsFile ✅​p ✅​p 🔄​f ✅​p ✅​p ✅​p
🔄​ TestFsCpSourceIsDirectoryButTargetIsFile/dbfs_to_local ✅​p ✅​p 🔄​f ✅​p ✅​p ✅​p
🟨​ TestFetchRepositoryInfoAPI_FromRepo 💚​R 💚​R 💚​R 💚​R 🟨​K 🟨​K
🟨​ TestFetchRepositoryInfoAPI_FromRepo/root 💚​R 💚​R 💚​R 💚​R 🟨​K 🟨​K
🟨​ TestFetchRepositoryInfoAPI_FromRepo/subdir 💚​R 💚​R 💚​R 💚​R 🟨​K 🟨​K
Top 3 slowest tests (at least 2 minutes):
duration env testname
5:39 aws windows TestAccept
3:22 azure windows TestAccept
3:22 gcp windows TestAccept

@pietern pietern left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is release_tagging.py still functional after tagging.py is updated?

@janniklasrose

janniklasrose commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

Is release_tagging.py still functional after tagging.py is updated?

Good question @pietern! TL;DR: identical behaviour, it's safe if we forget to cut over during the next genkit run.

Full explanation:

Once the upstream changes are merged, doing a generate without additional changes in CLI will continue to rewrite tagging.yml to run release_tagging.py.

our release_tagging.py monkey-patches the following methods to its own version:

  • get_next_tag_info
    • upstream changes will be ignored and release_tagging will function as it does now
  • clean_next_changelog
    • the upstream logic bypasses this method and runs a different one clean_nextchanges in the CLI repo
    • however, that upstream version will be identical to what we do currently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants