acceptance: make contains.py fail the test on a failed assertion#5466
Merged
Conversation
contains.py (#3345) printed `contains error:` to stderr but exited 0, so a failed assertion got baked into the golden output instead of failing the test. It now exits non-zero, so under the harness's `bash -euo pipefail` the script aborts. This surfaced a stale assertion in bundle/state/state_present (serial asserted as 11/12, but it's been 13 since the test was added); selftest/contains wraps its failing cases in errcode so the script still runs to completion. Co-authored-by: Isaac
denik
approved these changes
Jun 8, 2026
Collaborator
|
Commit: 8708875
22 interesting tests: 15 SKIP, 7 RECOVERED
Top 25 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
contains.py(#3345) printedcontains error:to stderr but exited 0, so a failed assertion got baked into the golden output instead of failing the test. It now exits non-zero, so under the harness'sbash -euo pipefailthe script aborts. This surfaced a stale assertion inbundle/state/state_present(serial asserted as11/12, but it's been13since the test was added);selftest/containswraps its failing cases inerrcodeso the script still runs to completion.This pull request and its description were written by Isaac.