Added support for UC external locations (direct mode only)#4484
Open
andrewnester wants to merge 9 commits intomainfrom
Open
Added support for UC external locations (direct mode only)#4484andrewnester wants to merge 9 commits intomainfrom
andrewnester wants to merge 9 commits intomainfrom
Conversation
andrewnester
requested review from
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 0fd9a36
30 interesting tests: 12 flaky, 7 KNOWN, 5 SKIP, 5 RECOVERED, 1 FAIL
Top 50 slowest tests (at least 2 minutes):
|
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
reviewed
Feb 11, 2026
Contributor
denik
left a comment
denik
left a comment
There was a problem hiding this comment.
Can you add config for invariant tests in acceptance/bundle/invariant?
denik
reviewed
Feb 11, 2026
| - field: storage_root | ||
| reason: immutable | ||
|
|
||
| external_locations: |
Contributor
There was a problem hiding this comment.
question - were you able to run 'make generate-direct' to update resources.generated.yml
Contributor
Author
There was a problem hiding this comment.
nope, it failed actually with
Traceback (most recent call last):
File "/Users/andrew.nester/cli/bundle/direct/tools/generate_resources.py", line 12, in <module>
import yaml
ModuleNotFoundError: No module named 'yaml'
which seems to be unrelated
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
| "custom_tags": | ||
| "description": |- | ||
| PLACEHOLDER | ||
| github.com/databricks/databricks-sdk-go/service/catalog.AwsSqsQueue: |
Contributor
There was a problem hiding this comment.
These descriptions should automatically be generated during the next CLI bump. Worth keeping an eye on because those descriptions will auto-generate our public documentation.
shreyas-goenka
approved these changes
Feb 16, 2026
Contributor
shreyas-goenka
left a comment
shreyas-goenka
left a comment
There was a problem hiding this comment.
Thanks, lgtm except one concern. Can you please TAL whether we can get test coverage for this on some cloud as well. Otherwise this can be fragile.
| } | ||
|
|
||
| func (e *ExternalLocation) GetURL() string { | ||
| // Return empty as external locations don't have a workspace URL |
Contributor
There was a problem hiding this comment.
optional: Can we still return the revelant s3 URL? Or any UI equivalent we have for the resource. This provides a nice experience when running bundle summary.
| Local = true | ||
| # External locations require actual storage credentials with cloud IAM setup | ||
| # which are environment-specific, so we only test locally with the mock server | ||
| Cloud = false |
Contributor
There was a problem hiding this comment.
Should we atleast run these tests on one cloud? Like just AWS maybe?
| # which are environment-specific, so we only test locally with the mock server | ||
| Cloud = false | ||
| RecordRequests = false | ||
| RequiresUnityCatalog = true |
Contributor
There was a problem hiding this comment.
optional: You can also set RunsOnDbr = true no to run these tests on DBR. It's opt-in for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Added support for UC external locations (direct mode only)
Why
This is a natural extension of support for UC catalogs where UC catalogs can have references to UC external locations.
Tests
Added an acceptance test