-
Notifications
You must be signed in to change notification settings - Fork 122
apps-mcp: add templates for Lakeflow jobs & pipelines templates #4183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lennartkats-db
wants to merge
5
commits into
main
Choose a base branch
from
lakeflow-mcp
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+994
−374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors init-template into dedicated subcommands with comprehensive L2 guidance for each resource type: - Add job subcommand using default-python template - Add pipeline subcommand using lakeflow-pipelines template - Add empty subcommand using default-minimal template - Create L2 templates: target_jobs, target_pipelines, target_mixed - Add AGENTS.tmpl for scaffolded projects - Parameterize default catalog in discover flow - Update detector to show "mixed" guidance for non-app-only projects - Move implementation to cmd/init_template/ subpackage - Make databricks_discover description more forceful (MANDATORY) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…y configMap conditionals - Add acceptance tests for job, pipeline, empty, and app init-template subcommands - Remove unnecessary 'if catalog != ""' checks (templates handle empty values) - Fix logdiag double-initialization in bundle detector - Simplify FormatProjectScaffoldSuccess output formatting
- Remove undefined listAllSkills parameter from generateDiscoverGuidance call - Fix test expectation: jobs-only projects now include "mixed" target type 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Collaborator
|
Commit: d481799
19 interesting tests: 18 KNOWN, 1 SKIP
Top 24 slowest tests (at least 2 minutes):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This extends
apps-mcpwith jobs & pipeline initialization:init_template.gointoinit_template/app.goinit_template/{job,pipeline,empty}.goand support for respective templatesWhy
We want to generalize
apps-mcpto other resource typesTests