Wait for app deletion in DoCreate instead of DoDelete #4176
+223
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varundeepsaini
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
denik
requested changes
Dec 29, 2025
denik
reviewed
Dec 29, 2025
denik
reviewed
Dec 29, 2025
varundeepsaini
force-pushed
the
fix-app-deletion-wait-in-create
branch
from
5ce6557 to
2459f80
Compare
Collaborator
|
Commit: 900e11a
21 interesting tests: 18 KNOWN, 2 flaky, 1 SKIP
Top 26 slowest tests (at least 2 minutes):
|
denik
reviewed
Dec 30, 2025
Contributor
denik
left a comment
denik
left a comment
There was a problem hiding this comment.
Thanks @varundeepsaini, looks good. Only have a comment about testing.
Could you also add NEXT_CHANGELOG entry?
bundle/direct/dresources/app_test.go
Outdated
|
|
||
| // TestAppDoCreate_FailsWhenAppExistsAndNotDeleting verifies that DoCreate returns | ||
| // a hard error when an app already exists but is NOT in DELETING state. | ||
| func TestAppDoCreate_FailsWhenAppExistsAndNotDeleting(t *testing.T) { |
Contributor
There was a problem hiding this comment.
The two tests above have special logic in the handler, so it makes sense to write them as unit tests. This test can be using standard handlers though, could you rewrite it as acceptance test?
first create app with the same name using databricks cli
$CLI apps create --json '{...}'
then do bundle deploy and observe the error:
musterr $CLI bundle deploy
Contributor
Author
There was a problem hiding this comment.
The testserver used to overwrite when an app already exists, i modified it so it returns a 409
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
denik
approved these changes
Dec 30, 2025
Contributor
|
Thanks @varundeepsaini ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves app deletion wait from
DoDeletetoDoCreate, and only retries when appropriate.Changes
RESOURCE_ALREADY_EXISTSerror, check app state via GET before retryingDELETINGstate or was just deleted (404)ACTIVE)Why?
bundle destroyFollow up to #4102, addresses feedback from #4006.