-
Notifications
You must be signed in to change notification settings - Fork 3
Customer managed VNet Terraform playbook #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Playbook for creating a Customer-managed VNet. Enables customers to set up a simple, production-grade workspace without additional help from STS.
|
Do you think it would be better to convert it to markdown instead of docx so it is readable on github/vscode? Any thoughts @andresgarciaf @haleyyyblue? |
|
Great question @jpgianfaldoni I’ve been thinking about it, and I believe we should keep the playbook standardization (including format decisions) pending for now since we have other higher-priority backlog items. Let’s focus on TF asset centralization first. |
|
My reason for using the docx/PDF format is that it is easy to download and share with customers. @gergelj is working on deploying a TF project that aligns with this document. We can add this playbook as a readme file under that, but my personal preference is to have a standalone playbook document for customers to use. |
haleyyyblue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the point that having a PDF version would be useful for customers.
However, before introducing multiple playbooks in different formats, we need to first discuss and establish a standardized framework for how we manage and maintain these playbooks.
If @gergelj and @OgnjenPantelic can integrate the current docx content into a Terraform project’s README.md file, we can review and merge it accordingly.
Simply uploading a docx file to GitHub does not provide version control or collaboration benefits, so I’d prefer to align with the Track Contributors to determine the best long-term approach for managing such documents.
Given that we already have several ongoing workspace setup service projects, setting up a comprehensive playbook management framework may not be feasible within this quarter.
Therefore, I cannot approve this PR at this stage. Instead, I’d like to ask you and @gergelj to start by submitting the Terraform project PR, referring to the GitHub philosophy for alignment.
Until we have a defined management process in place, please continue to manage customer-facing documents in the Content Repo (Confluence) and share PDFs with customers as needed.
504c423 to
db6edfc
Compare
Playbook for creating a Customer-managed VNet. Enables customers to set up a simple, production-grade workspace without additional help from STS.
Pull Request
Description
Brief description of what this PR does and why.
Adds a document playbook for Azure CM VNet with terraform
Category
Type of Change
Project Details
Project Name: Azure VNet injection Workspace Setup Guide (Terraform)
Purpose: Customer enablement
Technologies Used: Terraform, Databricks, Azure
Testing
Security Compliance ✅
By submitting this PR, I confirm I have followed the CONTRIBUTING.md guidelines and security requirements.