fix(ui): live-update runs list via websocket, page cleanup#101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The runs list wasn't reliably reflecting live websocket patches; also drops a dead prop and refreshes the loading skeleton.
What changed
processing-runs.vue: the runs list is now backed by a localdisplayRunsref synced from the fetch;onRunPatchmutates that ref (Object.assign) so WS patches render live, falling back to a full refresh for an unknown run id. Removes leftover debugconsole.logs.[id]/index.vue: redesigned the vjsf skeleton loader (a row of column skeletons instead of one block); drops the dead:is-smallprop.index.vue: drops the dead:is-smallprop.Why
Live run-status patches over WS didn't consistently update the rendered list;
is-smallwas an unused prop on both call sites.Regression risks
runs.data.value?.resultsdirectly to a watcheddisplayRunsref (watch isimmediate) — verify the pagination/refresh paths still populate it.is-smallremoved from<processing-actions>and the processings-list call sites — confirmed unused (no component declares the prop), but worth a glance.