ENH: delegate kron function.
#516
Open
+102
−81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The test fails with the I can update my delegation strategy to avoid delegating when the product of the shape elements equals zero (when using NumPy). What do you think about this? |
Member
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request introduces the
krondelegate function (#100).All supported backends already implement the
kronfunction. However, I wasn’t able to add support for the sparse backend because it requires all input sparse matrices to have a fill_value equal to zero (not the case in the test) - likely to avoid generating a large dense matrix.If you’d like to discuss potential support for kron in PyData Sparse, please let me know!
Feedback is welcome.