[unsupervised AI] fix: propagate task annotations during worker execution - #9340
Draft
rohitsalla wants to merge 2 commits into
Draft
[unsupervised AI] fix: propagate task annotations during worker execution#9340rohitsalla wants to merge 2 commits into
rohitsalla wants to merge 2 commits into
Conversation
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 40 files ± 0 40 suites ±0 14h 45m 0s ⏱️ - 10m 9s For more details on these failures, see this check. Results for commit 696800c. ± Comparison against base commit 40fcd99. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9138
What changed
This lets nested distributed computations inherit user annotations without accidentally constraining child scheduling to the parent task.
Verification
.venv/bin/python -m pytest -q distributed/tests/test_worker_client.py distributed/tests/test_spans.py.venv/bin/python -m pytest -q distributed/tests/test_actor.py::test_serialize_with_pickle.venv/bin/python -m pytest -q -o addopts='' -W default::pytest.PytestUnknownMarkWarning distributed/tests/test_client.py::test_secede_balances distributed/tests/test_worker.py::test_get_client.venv/bin/python -m ruff check distributed/worker.py distributed/tests/test_worker_client.py.venv/bin/python -m ruff format --check distributed/worker.py distributed/tests/test_worker_client.pygit diff --check