Skip to content

fix(dash-spv): remove overly-strict is_synced gate from broadcast #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
QuantumExplorer wants to merge 1 commit into
base: v0.42-dev
Choose a base branch
from
+1 −5
Open

fix(dash-spv): remove overly-strict is_synced gate from broadcast #656

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions dash-spv/src/client/transactions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
//! Transaction-related client APIs (e.g., broadcasting)

use crate::error::{NetworkError, Result, SpvError, SyncError};
use crate::error::{NetworkError, Result, SpvError};
use crate::network::NetworkManager;
use crate::storage::StorageManager;
use dashcore::network::message::NetworkMessage;
Expand All @@ -16,10 +16,6 @@ impl<W: WalletInterface, N: NetworkManager, S: StorageManager, H: EventHandler>
/// The transaction is also injected into the local message pipeline so that
/// the mempool manager processes it immediately.
pub async fn broadcast_transaction(&self, tx: &dashcore::Transaction) -> Result<()> {
if !self.sync_progress().await.is_synced() {
return Err(SpvError::Sync(SyncError::NotSynced));
}

let network_guard = self.network.lock().await;

if network_guard.peer_count() == 0 {
Expand Down
Loading