feat(transaction-view): optional amount accessory SF Symbol - #10
Merged
Conversation
An SF Symbol rendered immediately before the trailing DashAmount, in the secondary tone — for rows whose amount carries no direction, e.g. a circulating-arrows glyph on a wallet-internal transfer rendered with amountSign: .none. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The dashFont conversion turned two TextField prompts into some View. A prompt must be a Text, so both call sites failed to compile: SearchBar.swift:146 Cannot convert value of type 'some View' to Text AddressFieldView.swift:126 Reverts those two to .font(Font.dash.subhead), which is the correct call here regardless — dashFont pairs a font with a line height, and a line height cannot be applied to Text in the first place. Both files are wrapped in #if canImport(UIKit), so swift build on macOS never compiled them. Verified with xcodebuild against an iOS destination.
📝 WalkthroughWalkthroughThe PR updates iOS 17 prompt font modifiers and adds an optional SF Symbol accessory before transaction amounts in ChangesUI component updates
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
5 tasks
QuantumExplorer
added a commit
to dashpay/dashwallet-ios
that referenced
this pull request
Aug 10, 2026
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
QuantumExplorer
added a commit
to dashpay/dashwallet-ios
that referenced
this pull request
Aug 10, 2026
…a sign (#952) * feat(home): internal transfers render a circulating-arrows amount, not a sign An identity top-up read "+2 Đ" — like an external receive — when it only moved the wallet's own funds. Every internal history row now renders the amount signless with a circulating-arrows glyph before it (DashUIKit's new TransactionView.amountAccessorySystemImage): - main-feed rows with an internalTransferRoute (identity top-up / registration / invitation, to-Shielded, Shielded payout, to-Platform, self-sends) - internal shielded-activity rows (already signless; now carry the glyph) - the CoinJoin mixing group row External sends and receives keep their +/- signs. DashUIKit pin: master → feat/amount-accessory-icon (dashpay/DashUIKit#10, which also carries the TextField-prompt fix master needs to compile for iOS). Flip back to master once that PR merges. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * chore: DashUIKit pin back to master (dashpay/DashUIKit#10 merged) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(ui): metadata precedence for the internal-transfer amount treatment Merchant/gift-card metadata already wins over the route icons and title on a history row; give the amount the same precedence — the signless circulating-arrows treatment applies only to metadata-less internal moves. (No regression test: the unit-test target is pre-existing broken; verified by build + simulator smoke.) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
TransactionViewgains an optionalamountAccessorySystemImage— an SF Symbol rendered immediately before the trailingDashAmount, in the secondary tone. Meant for rows whose amount carries no direction, e.g. a circulating-arrows glyph on a wallet-internal transfer rendered withamountSign: .none(dashwallet-ios uses it for identity top-ups, to-Shielded/to-Platform transfers, self-sends, and CoinJoin mixing groups so they stop reading like external receives).Includes a preview ("Internal transfer — amount accessory").
Note
This branch also carries the
fix/textfield-prompt-typecommit (449c6ce) — currentmasterdoes not compile for an iOS consumer (SearchBarpassessome ViewwhereTextField(prompt:)requiresText). If that branch's PR merges first, this one rebases cleanly.🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Style Improvements
Screenshot
In dashwallet-ios: the internal "Identity top-up" row uses the accessory (
arrow.triangle.2.circlepath,amountSign: .none) while the external "Sent" row keeps its sign:(image served from the
pr10-assetsorphan branch — delete the branch after merge if unwanted)