ci(publish): switch trigger from pull_request to push#260
Merged
Conversation
The pull_request event sets GITHUB_REF to refs/pull/N/merge, which doesn't match the release environment's branch policy (main, create-pull-request/patch), causing the publish job to be rejected before execution with no logs. Switching to push trigger on main so GITHUB_REF is refs/heads/main, which satisfies the branch policy. - Replace pull_request closed trigger with push to main - Gate build job on commit message starting with 'Release ' - Remove PR-specific env vars and checks from release_check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pull_requestevent setsGITHUB_REFtorefs/pull/N/merge, which doesn't match thereleaseenvironment's branch deployment policy (main,create-pull-request/patch), causing the publish job to be silently rejected with no logspushtrigger onmainsoGITHUB_REFisrefs/heads/main, satisfying the branch policyReleaseto avoid unnecessary full matrix builds on every pushrelease_checkstepContext
This broke the v0.8.2 publish (run #23253907044) and the v0.8.1 publish (run #21916548701). After merging,
workflow_dispatchcan be used to publish v0.8.2.Test plan
ci(...)prefix should NOT trigger publish builds)gh workflow run publish.ymlto trigger v0.8.2 publish via workflow_dispatchreleaseenvironment deployment