Skip to content

Conversation

@sgrekhov
Copy link
Contributor

@sgrekhov sgrekhov commented Nov 7, 2025

Both testPart1() and testPart2() are asynchronous functions, and the test must await their completion. Otherwise, it may result in a false-positive outcome when running in browser environments.

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eernstg eernstg merged commit e4ea9b4 into dart-lang:master Nov 10, 2025
2 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Nov 14, 2025
2025-11-13 sgrekhov22@gmail.com dart-lang/co19#3315. Move other `grammar_*` to `Primary-constructors` (dart-lang/co19#3391)
2025-11-13 sgrekhov22@gmail.com dart-lang/co19#3315. Move/add name conflict tests to `Primary-constructors`. (dart-lang/co19#3393)
2025-11-12 sgrekhov22@gmail.com dart-lang/co19#3315. Add grammar tests for `factory()` (dart-lang/co19#3390)
2025-11-11 sgrekhov22@gmail.com dart-lang/co19#3315. Move `grammar_A01_t*` to `Primary-constructors` (dart-lang/co19#3389)
2025-11-11 sgrekhov22@gmail.com dart-lang/co19#3330. Add test for the lexical lookup (dart-lang/co19#3387)
2025-11-11 sgrekhov22@gmail.com dart-lang/co19#3330. Add static extensions tests. Part 2. (dart-lang/co19#3382)
2025-11-11 sgrekhov22@gmail.com dart-lang/co19#3330. Add debugger tests for static extensions (dart-lang/co19#3383)
2025-11-10 sgrekhov22@gmail.com dart-lang/co19#2825. Fix async functions call in scope_A06_t02.dart (dart-lang/co19#3386)
2025-11-07 biggs0125@gmail.com Use correct async helpers and awaits in LanguageFeatures/Parts-with-imports/scope_A06_t03.dart (dart-lang/co19#3384)

R=athom@google.com, eernst@google.com

Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try,dart2js-minified-linux-d8-try
Change-Id: I308e558680dded4d76eb701a8033ae2dbd758505
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/461821
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants