Add logging of the compile step. #4279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
davidmorgan
force-pushed
the
log-compiling
branch
4 times, most recently
from
d26a4dd to
6951e2b
Compare
jensjoha
approved these changes
Nov 21, 2025
davidmorgan
force-pushed
the
log-compiling
branch
from
6951e2b to
b788e86
Compare
Contributor
Author
|
Whoops, should have merged instead of rebased, sorry. Force push was just updating version numbers in pubspecs+changelogs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like we should show what is going on with the compile, before adding any complexity about choosing to do an AOT compile vs a JIT compile :)
So, log it and how long it's taking.
Also improve logging around restarts, so they show with the same headers as a series of builds in watch mode.