fix: don't switch view from inside Gtk event delivery - #21867
Open
da-phil wants to merge 1 commit into
Open
Conversation
A view switch removes every lib module widget from its container and leaves
the thumbtable parentless until the filmstrip re-parents it from its draw
handler. Done from a gesture handler, this unrealizes widgets Gtk is still
propagating the current event through:
Gtk-CRITICAL gtk_widget_event: assertion
'WIDGET_REALIZED_FOR_EVENT (widget, event)' failed
It shows on every darkroom entry since 650a5ff put the thumbtable click
gesture in the capture phase, where the handler runs before Gtk propagates
the press.
Postpone the switch to a G_PRIORITY_HIGH idle while an event is being
delivered -- g_main_context_invoke() does not, on the gui thread it runs the
callback synchronously -- and let the thumbtable/culling double-click go
through dt_ctl_switch_mode_to() rather than switching directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A view switch removes every lib module widget from its container and leaves the thumbtable parentless until the filmstrip re-parents it from its draw handler. Done from a gesture handler, this unrealizes widgets Gtk is still propagating the current event through:
The inline switch on double-click dates back to 8af6194, but was harmless
as long as the gesture ran in the bubble phase: the handler was then reached
through the widget itself, and propagation stopped right after it on the now
parentless thumbtable. It only became visible when 650a5ff moved the
thumbtable click gesture to the capture phase, where the handler runs before
Gtk propagates the press.
Postpone the switch to a G_PRIORITY_HIGH idle while an event is being
delivered -- g_main_context_invoke() does not, on the gui thread it runs the
callback synchronously -- and let the thumbtable/culling double-click go
through dt_ctl_switch_mode_to() rather than switching directly.
Fixes: #21862
Disclaimer: this work has been co-created with Claude.