cmake: link libwayland-client when GTK3 has the Wayland backend - #21865
Open
da-phil wants to merge 1 commit into
Open
cmake: link libwayland-client when GTK3 has the Wayland backend#21865da-phil wants to merge 1 commit into
da-phil wants to merge 1 commit into
Conversation
gui/gtk.c calls into libwayland-client directly to detect server-side decoration support, but gtk+-3.0.pc does not list wayland-client. The symbols were only resolved by accident, via libgdk-3's own DT_NEEDED, which breaks on distros linking with `-Wl,--no-undefined`, e.g. openSUSE puts it in the default LDFLAGS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first step of fixing the currently failing SuSE OBS builds, by explicitly linking against wayland client when GTK3 has the wayland backend.
gui/gtk.c calls into libwayland-client directly to detect server-side decoration support, but gtk+-3.0.pc does not list wayland-client. The symbols were only resolved by accident, via libgdk-3's own DT_NEEDED, which breaks on distros linking with
-Wl,--no-undefined, e.g. openSUSE puts it in the default LDFLAGS.The following builds are failing since around 2026-02-07 due to this issue:
I'm currently also looking into fixing the issue that darktable-mcp is built but not packaged within the OBS builds:
This is going to be fixed within the OBS repo, by adding darktable-mcp to the darktable.spec, darktable.dsc and debian.tar.xz files.