mask manager: fix use-after-free when selecting a group - #21861
Open
da-phil wants to merge 1 commit into
Open
Conversation
Tree rows keep raw dt_iop_module_t pointers, but modules are freed on image change and on darkroom leave. The structure-hash early-out in gui_update can keep a store built for the previous set of modules, so selecting a group row called flags() through a dangling pointer and segfaulted. Drop dead modules in _lib_masks_get_values() and invalidate the cached tree hash on image change and darkroom entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tree rows keep raw dt_iop_module_t pointers, but modules are freed on image change and on darkroom leave. The structure-hash early-out in gui_update can keep a store built for the previous set of modules, so selecting a group row called flags() through a dangling pointer and segfaulted.
Drop dead modules in _lib_masks_get_values() and invalidate the cached tree hash on image change and darkroom entry.
Fixes: #21852
Disclaimer: this work has been co-created with Claude.