tests: fix unit test link error in Debug builds - #21857
Merged
TurboGit merged 1 commit intoAug 16, 2026
Merged
Conversation
get_pixel() was defined as a plain C99 `inline` in testimg.h, which is not an external definition. Release builds inline it away, but at -O0 every call site emits a reference to an out-of-line symbol that no translation unit provides, breaking the link of test_filmicrgb. Make it `static inline`.
da-phil
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background: get_pixel() was defined as a plain C99
inlinein testimg.h, which is not an external definition.Release builds inline it away, but at -O0 or when enabling debug symbols every call site emits a reference to an out-of-line symbol that no translation unit provides, breaking the link of test_filmicrgb.
Solution: Make it
static inline.This hasn't been caught by our newly added unit test to the gitlab ci, because it builds darktable via
-O3 -DNDEBUG.