Skip to content

Try using clEnqueueMigrateMemObjects#21121

Closed
jenshannoschwalm wants to merge 3 commits into
darktable-org:masterfrom
jenshannoschwalm:try_migration
Closed

Try using clEnqueueMigrateMemObjects#21121
jenshannoschwalm wants to merge 3 commits into
darktable-org:masterfrom
jenshannoschwalm:try_migration

Conversation

@jenshannoschwalm

Copy link
Copy Markdown
Collaborator

See #21069

  1. Just brute force usage in dt_opencl_copy_device_to_host() as that was the reported bottleneck
  2. Here on AMD/rusticl with unified mem
    a) no critical performance drops
    b) no reported errors
    c) no instabilities

@jenshannoschwalm jenshannoschwalm self-assigned this May 24, 2026
@jenshannoschwalm jenshannoschwalm added wip pull request in making, tests and feedback needed OpenCL Related to darktable OpenCL code labels May 24, 2026
@jenshannoschwalm jenshannoschwalm marked this pull request as draft May 24, 2026 15:39
@jenshannoschwalm

Copy link
Copy Markdown
Collaborator Author

Also tested on rocm, that might be a bit slower but otherwise no problems ...

@da-phil

da-phil commented May 24, 2026

Copy link
Copy Markdown
Contributor

Works for me on my Radeon 780M iGPU w/ 10 GB of GTT mem using ROCm 7.2.1.
A quick test just exporting an image gave me the following results:

On this branch:

[dev_process_export] pixel pipeline processing took 8.728 secs (19.154 CPU)

With current master:

[dev_process_export] pixel pipeline processing took 8.154 secs (20.413 CPU)

@jenshannoschwalm

Copy link
Copy Markdown
Collaborator Author

A quick test just exporting an image gave me the following results:

About what i find here. Let's see if it would help on DGX Spark...

- dt_clEnqueueMigrateMemObjects
- dt_clEnqueueFillBuffer
- dt_clEnqueueFillImage
all are safe for OpenCL 1.2 API so no special treatment is required.
@jenshannoschwalm

Copy link
Copy Markdown
Collaborator Author

Closing as this is not the way to go for now

@jenshannoschwalm jenshannoschwalm deleted the try_migration branch May 25, 2026 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OpenCL Related to darktable OpenCL code wip pull request in making, tests and feedback needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants