restrict metadata tag list in metadata editor #20149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zisoft
force-pushed
the
restrict-metadata-tags
branch
from
4adf53e to
cd56d98
Compare
Member
|
@TurboGit you might want to consider this for 5.4.1 to "stop the bleeding" since in it's current state metadata editor can add arbitrary Exif tags, but they don't react the way that the users think they should (display information from exif fields in the image that darktable doesn't support). I'm working on solutions to both use cases raised in #19306
|
zisoft
force-pushed
the
restrict-metadata-tags
branch
from
cd56d98 to
2f1156f
Compare
TurboGit
added
bugfix
The metadata editor should only allow to edit tags which are supposed to be user-editable.
zisoft
force-pushed
the
restrict-metadata-tags
branch
from
2f1156f to
a5b5f12
Compare
Member
|
Merged in master and 5.4.1. Thanks for looking into this. |
Collaborator
Author
|
Release notes: The list of the allowed tags in the metadata editor preferences has been restricted to tags which are supposed to be user-editable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metadata editor should only allow to edit tags which are supposed to be user-editable.
Some users add exif tags to the metadata editor which leads to some confusion as it does not work as the user expects.
See #19973, #19366
This PR restricts the list of allowed metadata tags in the metadata editor preferences dialog to:
@wpferguson : please decide if #19973 can be closed with this change.