Skip to content

Would love to see the addition of recursion in solutions to Q2#105

Closed
Lord-of-Bugs wants to merge 10 commits into
darkprinx:masterfrom
Lord-of-Bugs:master
Closed

Would love to see the addition of recursion in solutions to Q2#105
Lord-of-Bugs wants to merge 10 commits into
darkprinx:masterfrom
Lord-of-Bugs:master

Conversation

@Lord-of-Bugs

Copy link
Copy Markdown

I solved Q2 more concisely and structurally elegant using recursion.

@darkprinx

Copy link
Copy Markdown
Owner

Thanks for putting this together! Looking at the diff, it goes further than the title suggests — it touches all 8 notebooks (Day_01–Day_08), and in several spots it replaces/removes existing solutions rather than adding alongside them (e.g. the deposit/withdraw logic in Day_05 Q17, the generator/list-comprehension alternatives in Day_01) instead of just adding the new recursive Q2 solution. Could you rescope this down to the intended addition(s), or split it into separate PRs per day/question? Happy to merge once it's additions-only — don't want to lose other contributors' solutions in the process.

@darkprinx

Copy link
Copy Markdown
Owner

Followed up on this since it's been a couple hours without a response — went through the full diff hunk by hunk against all 8 notebooks. Every hunk either deletes/replaces an existing contributor's solution (e.g. it removes the "Using For Loop"/"Using While Loop" alternatives for Q2, and removes leonedott's and another contributor's Q17 solutions entirely, replacing them with your own versions) or is an empty trailing cell — there's no hunk in the whole diff that's a pure addition.

On top of that, both things this PR sets out to add have since landed independently through smaller, non-destructive PRs: a "Using recursion" solution for Q2 (via #141) and a dictionary-based solution for Q17 (via #80, the etanios solution using a transactions dict) are both already on master.

Since there's nothing left to add that isn't already there, and merging as-is would drop other contributors' solutions across 8 days, I'm closing this rather than merging. Really appreciate you taking the time to put this together — if you'd like to contribute a specific addition instead (one method, one question, one file), very happy to take a fresh PR for that. Thanks!

@darkprinx darkprinx closed this Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants