Repository navigation
Conversation
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
…-overwrite-actor Signed-off-by: Cassandra Coyle <cassie@diagrid.io> # Conflicts: # tests/actor/test_grpc_host.py
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1347 +/- ##
==========================================
+ Coverage 88.18% 88.61% +0.43%
==========================================
Files 165 165
Lines 13432 13537 +105
==========================================
+ Hits 11845 11996 +151
+ Misses 1587 1541 -46 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
nelson-parente
previously approved these changes
Oct 26, 2026
nelson-parente
left a comment
nelson-parente
left a comment
Contributor
There was a problem hiding this comment.
LGTM. The validate-dapr-head failure is the durabletask e2e "no workflow worker is connected" race, unrelated.
JoshVanL
requested changes
Oct 27, 2026
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pairs with dapr/dapr#10748, which sends
Dapr-Actor-Activation-Idon actor callbacks.After daprd is killed the app keeps its actor objects, and the new daprd never sends DELETE for them. The SDK reused the stale object and its next save could overwrite newer state.
_on_deactivatethe old object (errors logged), activate a fresh one_on_post_actor_method, then skips the save and failsdispatch,fire_reminderandfire_timertake an optionalactivation_id, public API unchangedNot covered: a save already in flight can still land late. Etags on actor state are a follow-up.