Skip to content

style: update qs times and wf names#1071

Open
sicoyle wants to merge 3 commits into
dapr:mainfrom
sicoyle:fix/update-quickstart-to-rerun-fine
Open

style: update qs times and wf names#1071
sicoyle wants to merge 3 commits into
dapr:mainfrom
sicoyle:fix/update-quickstart-to-rerun-fine

Conversation

@sicoyle
Copy link
Copy Markdown
Contributor

@sicoyle sicoyle commented Jun 1, 2026

Description

I used this to demo at KCD. If you rerun then you get a ton of conflicts on wf names and such. These were some of the tweaks I needed to rerun this properly.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Samantha Coyle <sam@diagrid.io>
Copilot AI review requested due to automatic review settings June 1, 2026 14:00
@sicoyle sicoyle requested review from a team as code owners June 1, 2026 14:00
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the examples/workflow/simple.py workflow example to be easier to re-run without instance ID collisions and to be more tolerant of timing variability during the demo flow.

Changes:

  • Generate a unique workflow instance_id using a UUID to reduce conflicts across repeated runs.
  • Increase sleep durations to allow more time for workflow progression before subsequent operations.
  • Relax early assertions on counter and retry_count to be non-strict (>=) instead of exact equality.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread examples/workflow/simple.py Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.66%. Comparing base (bffb749) to head (a43c340).
⚠️ Report is 137 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1071      +/-   ##
==========================================
- Coverage   86.63%   82.66%   -3.97%     
==========================================
  Files          84      146      +62     
  Lines        4473    14693   +10220     
==========================================
+ Hits         3875    12146    +8271     
- Misses        598     2547    +1949     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sicoyle and others added 2 commits June 1, 2026 09:12
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Sam <sam@diagrid.io>
Signed-off-by: Samantha Coyle <sam@diagrid.io>
Copy link
Copy Markdown
Contributor

@seherv seherv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The >= is a nice change, I'd do that in other examples too.

nit: I'd use 1 + 10 and explain they're the inputs of the two activities

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants