style: update qs times and wf names#1071
Conversation
Signed-off-by: Samantha Coyle <sam@diagrid.io>
There was a problem hiding this comment.
Pull request overview
This PR updates the examples/workflow/simple.py workflow example to be easier to re-run without instance ID collisions and to be more tolerant of timing variability during the demo flow.
Changes:
- Generate a unique workflow
instance_idusing a UUID to reduce conflicts across repeated runs. - Increase sleep durations to allow more time for workflow progression before subsequent operations.
- Relax early assertions on
counterandretry_countto be non-strict (>=) instead of exact equality.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1071 +/- ##
==========================================
- Coverage 86.63% 82.66% -3.97%
==========================================
Files 84 146 +62
Lines 4473 14693 +10220
==========================================
+ Hits 3875 12146 +8271
- Misses 598 2547 +1949 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Sam <sam@diagrid.io>
Signed-off-by: Samantha Coyle <sam@diagrid.io>
seherv
left a comment
There was a problem hiding this comment.
The >= is a nice change, I'd do that in other examples too.
nit: I'd use 1 + 10 and explain they're the inputs of the two activities
Description
I used this to demo at KCD. If you rerun then you get a ton of conflicts on wf names and such. These were some of the tweaks I needed to rerun this properly.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: