[cicoyle]

Pairs with the dapr/dapr change that sends Dapr-Actor-Activation-Id on actor callbacks.

After daprd is killed the app keeps its actor objects, and the new daprd never sends DELETE for them. The SDK reused the stale object, skipped onActivate and kept its in-memory fields.

• new id: onDeactivate the old object (errors logged), activate a fresh one
• same id or no id (older daprd): reuse, same as today
• a call on a replaced or deleted object still runs onPostActorMethod, then skips the save and fails with IllegalStateException
• a late first activation never replaces a newer one, a different id fails
• ActorRuntime and DaprController get overloads with the id, old signatures still work
• HTTP only, this SDK has no gRPC actor callback stream

Not covered: a save already in flight can still land late. Etags on actor state are a follow-up.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

[codecov]

Codecov Report

❌ Patch coverage is 97.46835% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.71%. Comparing base (ca2a930) to head (c5ee38a).
⚠️ Report is 14 commits behind head on master.

Files with missing lines	Patch %	Lines
...main/java/io/dapr/actors/runtime/ActorManager.java	96.77%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #1876      +/-   ##
============================================
+ Coverage     79.69%   80.71%   +1.02%     
- Complexity     2687     2876     +189     
============================================
  Files           267      274       +7     
  Lines          7933     8467     +534     
  Branches        842      911      +69     
============================================
+ Hits           6322     6834     +512     
- Misses         1255     1266      +11     
- Partials        356      367      +11     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[nelson-parente]

#1840 added the gRPC actor event stream after this branched. ActorEventDispatcher on master calls runtime.invoke, invokeReminder and invokeTimer without the activation id, so stream-hosted actors keep the stale object. Can you rebase and pass the id from request.getMetadata() there?

[JoshVanL]

The discarded actor's onDeactivate can still save state, which brings back the overwrite this PR is meant to stop.

onDeactivateInternal clears the state cache and then calls the user's onDeactivate. Nothing stops that override from calling getActorStateManager().set(...) and then saveState(). A common pattern is to keep a counter in a field and write it on deactivation. After a daprd restart another host may have committed a newer value, and when the new activation id arrives (line 86), the stale actor writes its old value over it.

Suggest making a discarded actor refuse saves, for example a flag set here before onDeactivateInternal and checked in ActorStateManager.save() (which covers both saveState() and a direct getActorStateManager().save()). That keeps onDeactivate available for releasing resources without letting it write.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.