Repository navigation
test: wait for outbox subscription in ProducerAppIT - #1872
Merged
dapr-bot merged 1 commit intoOct 26, 2026
Merged
Conversation
The test only waited for the declarative "topic" subscription, which daprd lists before it sees the app as healthy. The outbox POST could then reach daprd before it subscribed to the outbox topics, and RabbitMQ dropped the unroutable message. Also wait for the app-declared "outbox-topic" subscription. Signed-off-by: Javier Aliaga <javier@diagrid.io>
JoshVanL
approved these changes
Oct 26, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1872 +/- ##
=========================================
Coverage 80.21% 80.21%
Complexity 2801 2801
=========================================
Files 273 273
Lines 8278 8278
Branches 896 896
=========================================
Hits 6640 6640
Misses 1272 1272
Partials 366 366 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dapr-bot
added a commit
that referenced
this pull request
Oct 26, 2026
The test only waited for the declarative "topic" subscription, which daprd lists before it sees the app as healthy. The outbox POST could then reach daprd before it subscribed to the outbox topics, and RabbitMQ dropped the unroutable message. Also wait for the app-declared "outbox-topic" subscription. (cherry picked from commit 00f769f) Signed-off-by: Javier Aliaga <javier@diagrid.io> Co-authored-by: Javier Aliaga <javier@diagrid.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ProducerAppIT.testOrdersOutboxEndpointAndMessagingfails intermittently in the dapr/daprdapr-test-sdknightly run (2026-10-23 and 2026-10-26, e.g. https://github.com/dapr/dapr/actions/runs/40251991248/job/121345718767) withexpected <1> but was <0> within 15 seconds.setUponly waited for thetopicsubscription. That subscription is declarative, so daprd lists it in metadata before it sees the app as healthy. daprd subscribes tooutbox-topicand to the internal outbox topic only once the app is healthy. When the outbox POST arrives before that, RabbitMQ drops the unroutable message and the event never reaches the subscriber.This PR also waits for the
outbox-topicsubscription, which the app declares through@Topic. daprd lists it only once it has seen the app as healthy and starts subscribing.DaprPubSubOutboxITalready waits for its outbox topic the same way.Verified locally:
ProducerAppITpasses (2/2) without the temporary endpoint.Issue reference
No issue; CI flake in dapr/dapr
dapr-test-sdk.Checklist