Repository navigation
Support the binary store API (alpha) from Dapr 1.19 - #1870
Merged
Merged
Conversation
Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>
Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>
Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>
Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>
…apr#1851) Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>
Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>
Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>
Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1870 +/- ##
============================================
+ Coverage 80.21% 80.46% +0.25%
- Complexity 2801 2835 +34
============================================
Files 273 274 +1
Lines 8278 8412 +134
Branches 896 905 +9
============================================
+ Hits 6640 6769 +129
- Misses 1272 1277 +5
Partials 366 366 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
javier-aliaga
approved these changes
Oct 26, 2026
javier-aliaga
pushed a commit
that referenced
this pull request
Oct 26, 2026
* feat: add deleteBinaryFile to DaprPreviewClient (#1851) * feat: add getBinaryFile to DaprPreviewClient (#1851) * fix: apply backpressure to getBinaryFile downloads (#1851) * feat: add setBinaryFile to DaprPreviewClient (#1851) * fix: report the content error once when a binary file upload fails (#1851) * docs: add binary store example (#1851) * test: add binary store integration test (#1851) * fix: tighten binary store cancel and error paths (#1851) --------- (cherry picked from commit 53373f4) Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com> Co-authored-by: Siri Varma Vegiraju <siri.varma@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds client support for the binary store building block (alpha) from Dapr 1.19. An app can store, read, and delete files as byte streams through a binary store component.
New methods on
DaprPreviewClient:setBinaryFile(SetBinaryFileRequestAlpha1)andsetBinaryFile(storeName, fileName, byte[], overwrite). The client sendsinitial_requestfirst, then the content in chunks of at most 32 KiB, withseqfrom 0. Ifoverwriteis false and the file exists, the call fails withALREADY_EXISTS.getBinaryFile(storeName, fileName)returnsFlux<byte[]>. The client asks gRPC for messages only when the subscriber has demand, so a slow subscriber does not make the client buffer the whole file. If the subscriber cancels, the gRPC call is cancelled.getBinaryFileBytes(storeName, fileName)returns the whole file asMono<byte[]>.deleteBinaryFile(storeName, fileName)returnsMono<Void>.The request class is
io.dapr.client.domain.SetBinaryFileRequestAlpha1. It follows the pattern ofEncryptRequestAlpha1.Errors keep their gRPC status code. For example, a missing file gives
DaprExceptionwith error codeNOT_FOUND.Known limit: upload does not use gRPC flow control, the same as crypto
encrypt. If the contentFluxproduces data faster than the network sends it, gRPC holds the extra data in memory. The Javadoc says this.Other changes:
DaprPreviewClientBinaryStoreIT: a Testcontainers test against daprd 1.19.0 with thebinarystore.in-memorycomponent. It covers small and 1 MiB round trips,overwritetrue and false, and read after delete.examples/.../binarystore: an example and a README thatmm.pyruns. The README is added tovalidate.yml.The API is alpha, so its names and behavior can change in a later release. Docs for dapr/docs will follow in a separate PR.
Issue reference
Please reference the issue this PR will close: #1851
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: