Skip to content

fix: allow workflow_dispatch for v1.17 SWA deployment#5133

Open
paulyuk wants to merge 3 commits intov1.17from
fix/workflow-dispatch-v1-17
Open

fix: allow workflow_dispatch for v1.17 SWA deployment#5133
paulyuk wants to merge 3 commits intov1.17from
fix/workflow-dispatch-v1-17

Conversation

@paulyuk
Copy link
Copy Markdown
Contributor

@paulyuk paulyuk commented Apr 21, 2026

Problem

The build job condition only allows push and pull_request events:

if: github.event_name == 'push' || (github.event_name == 'pull_request' && github.event.action != 'closed')

workflow_dispatch is excluded, so manual triggers skip the build.

Fix

Use the same condition as website-root.yml:

if: github.event.action != 'closed'

This works for all event types (push, pull_request, workflow_dispatch) and only skips the closed PR action.

Context

Needed after migrating SWAs to the new Azure subscription. When merged, the push event will trigger deployment to the new SWA.

@paulyuk paulyuk requested review from a team as code owners April 21, 2026 23:43
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 21, 2026

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ashy-coast-091fbe31e-5133.westus2.7.azurestaticapps.net

@paulyuk paulyuk force-pushed the fix/workflow-dispatch-v1-17 branch from b9e18cb to d549a02 Compare April 22, 2026 06:46
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ashy-coast-091fbe31e-5133.westus2.7.azurestaticapps.net

1 similar comment
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ashy-coast-091fbe31e-5133.westus2.7.azurestaticapps.net

@paulyuk paulyuk force-pushed the fix/workflow-dispatch-v1-17 branch from 606e80a to cb623d9 Compare April 22, 2026 07:02
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ashy-coast-091fbe31e-5133.westus2.7.azurestaticapps.net

@paulyuk paulyuk force-pushed the fix/workflow-dispatch-v1-17 branch from cb623d9 to 5a4e5e9 Compare April 22, 2026 07:08
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ashy-coast-091fbe31e-5133.westus2.7.azurestaticapps.net

@paulyuk paulyuk force-pushed the fix/workflow-dispatch-v1-17 branch from 5a4e5e9 to 0dfe765 Compare April 22, 2026 07:18
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ashy-coast-091fbe31e-5133.westus2.7.azurestaticapps.net

@paulyuk paulyuk force-pushed the fix/workflow-dispatch-v1-17 branch from 0dfe765 to 35df434 Compare April 22, 2026 07:30
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ashy-coast-091fbe31e-5133.westus2.7.azurestaticapps.net

@paulyuk paulyuk force-pushed the fix/workflow-dispatch-v1-17 branch from 35df434 to d6b47bc Compare April 22, 2026 07:35
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ashy-coast-091fbe31e-5133.westus2.7.azurestaticapps.net

@paulyuk paulyuk force-pushed the fix/workflow-dispatch-v1-17 branch from d6b47bc to a20d1ed Compare April 22, 2026 07:50
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ashy-coast-091fbe31e-5133.westus2.7.azurestaticapps.net

@paulyuk paulyuk force-pushed the fix/workflow-dispatch-v1-17 branch from a20d1ed to 39eca20 Compare April 22, 2026 07:56
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ashy-coast-091fbe31e-5133.westus2.7.azurestaticapps.net

@paulyuk
fix: allow workflow_dispatch + trim non-content assets for Free tier
5b45bd4 
Signed-off-by: paulyuk <paulyuk@microsoft.com>
@paulyuk paulyuk force-pushed the fix/workflow-dispatch-v1-17 branch from 39eca20 to 5b45bd4 Compare April 22, 2026 08:00
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ashy-coast-091fbe31e-5133.westus2.7.azurestaticapps.net

marcduiker
marcduiker approved these changes Apr 24, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@marcduiker marcduiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 24, 2026

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ashy-coast-091fbe31e-5133.westus2.7.azurestaticapps.net

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 28, 2026

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ashy-coast-091fbe31e-5133.westus2.7.azurestaticapps.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcduiker marcduiker marcduiker approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@paulyuk @marcduiker