[1.18] Enable WorkflowsRemoteActivityReminder feature by default#5128
Open
JoshVanL wants to merge 1 commit intodapr:v1.18from
Open
[1.18] Enable WorkflowsRemoteActivityReminder feature by default#5128JoshVanL wants to merge 1 commit intodapr:v1.18from
JoshVanL wants to merge 1 commit intodapr:v1.18from
Conversation
Signed-off-by: joshvanl <me@joshvanl.dev>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Dapr 1.18 documentation to reflect that the WorkflowsRemoteActivityReminder (Durable Activity Results) feature gate is enabled by default starting in v1.18, and adjusts guidance for multi-application workflows accordingly.
Changes:
- Update the preview features table entry to state the gate is enabled by default as of v1.18.
- Update multi-application workflow docs to clarify behavior/guidance across 1.17 vs 1.18 defaults.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| daprdocs/content/en/operations/support/support-preview-features.md | Updates the preview-features table entry for WorkflowsRemoteActivityReminder to reflect v1.18 default behavior. |
| daprdocs/content/en/developing-applications/building-blocks/workflow/workflow-multi-app.md | Updates the “Durable Activity Results” section to reflect 1.18 default enablement and 1.17 opt-in guidance. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| | **Subscription Hot Reloading** | Allows for declarative subscriptions to be "hot reloaded". A subscription is reloaded either when it is created/updated/deleted in Kubernetes, or on file in self-hosted mode. In-flight messages are unaffected when reloading. | `HotReload`| [Hot Reloading]({{% ref "subscription-methods.md#declarative-subscriptions" %}}) | v1.14 | | ||
| | **Workflows Clustered Deployment** | Enable Workflows to function when workflow clients communicate to multiple daprds of the same appID who are behind a loadbalancer. Only relevant when using [Dapr shared]({{% ref "kubernetes-dapr-shared" %}}) | `WorkflowsClusteredDeployment`| [Dapr Shared]({{% ref "kubernetes-dapr-shared" %}}) | v1.16 | | ||
| | **Workflows Durable Activity Results** | If set, ensures that activity results are durably sent to the owning workflow in multi-application scenarios, even when the owning workflow application is unavailable. Unless running multiple Dapr versions, this feature gate should be enabled. Disabled by default for backwards compatibility. | `WorkflowsRemoteActivityReminder` | [Multi-application Workflows]({{% ref "workflow-multi-app.md#durable-activity-results" %}}) | v1.17 | | ||
| | **Workflows Durable Activity Results** | If set, ensures that activity results are durably sent to the owning workflow in multi-application scenarios, even when the owning workflow application is unavailable. Strongly recommended to always be enabled when all Dapr applications are running the same version. Enabled by default as of v1.18. | `WorkflowsRemoteActivityReminder` | [Multi-application Workflows]({{% ref "workflow-multi-app.md#durable-activity-results" %}}) | v1.17 | |
Comment on lines
+107
to
+108
| This option should be enabled by all users who have all applications running Dapr version 1.17 or later. | ||
| As of 1.18 it is _**enabled** by default_. In 1.17 it was disabled by default for backwards compatibility between Dapr versions, and can be opted into via the feature gate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.