Skip to content

Preventing maintainer docs from automerging if marked with "do-not-merge" label#5111

Open
WhitWaldo wants to merge 2 commits intodapr:v1.17from
WhitWaldo:bot-no-merge
Open

Preventing maintainer docs from automerging if marked with "do-not-merge" label#5111
WhitWaldo wants to merge 2 commits intodapr:v1.17from
WhitWaldo:bot-no-merge

Conversation

@WhitWaldo
Copy link
Copy Markdown
Contributor

@WhitWaldo WhitWaldo commented Apr 12, 2026

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within tabpane
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have tabpane

In addition, please fill out the following to help reviewers understand this pull request:

Description

Adding guard to prevent PRs from merging that would otherwise be acceptable when they're marked with the "do-not-merge" label. Automatically runs whenever a label is removed in case the do-not-merge is removed (prompting immediate merge if conditions are acceptable).

Further, if a non-maintainer opens a PR against docs that's restricted only to a single SDK directory, a maintainer of that group can add their "automerge: " label to it and that'll suffice to trigger the bot and allow automerge. There are some variations made on this theme:

  • If an "automerge: " label is applied and the changes in the PR don't correspond to the directory of the applied label, the label will be removed and the automerge will not happen.
  • If an SDK maintainer comes along and applies an "automerge: " label for an SDK they're not a maintainer of, the label will be removed and the automerge will not happen
  • If anyone at all comes along and applies an "automerge: " label and they're not part of the maintainer group corresponding with the label, the label will be removed and the automerge will not happen.

Issue reference

…ptable when they're marked with the "do-not-merge" label. Automatically runs whenever a label is removed in case the do-not-merge is removed (prompting immediate merge if conditions are acceptable)

Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
@WhitWaldo WhitWaldo self-assigned this Apr 12, 2026
@WhitWaldo WhitWaldo added the github_actions Pull requests that update GitHub Actions code label Apr 12, 2026
@WhitWaldo WhitWaldo requested review from a team as code owners April 12, 2026 18:49
If an "automerge: " label is applied and the changes in the PR don't correspond to the directory of the applied label, the label will be removed and the automerge will not happen.
If an SDK maintainer comes along and applies an "automerge: " label for an SDK they're not a maintainer of, the label will be removed and the automerge will not happen
If anyone at all comes along and applies an "automerge: " label and they're not part of the maintainer group corresponding with the label, the label will be removed and the automerge will not happen.

Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant