DAOS-19620 object: unlock cob_lock on single-replica EIO - #19043
Open
meire-volumez wants to merge 1 commit into
Open
DAOS-19620 object: unlock cob_lock on single-replica EIO#19043meire-volumez wants to merge 1 commit into
meire-volumez wants to merge 1 commit into
Conversation
obj_replica_leader_select() doesn't release cob_lock in the grp_size == 1 branch, skipping the unlock label that every other exit uses. The next write lock on that object then blocks forever. Return through the unlock label instead, with D_GOTO(unlock, rc = -DER_IO). Signed-off-by: Meir Elisha <meir.elisha@volumez.com>
|
Ticket title is 'obj_replica_leader_select() leaks cob_lock read lock on single-replica -DER_IO path' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
obj_replica_leader_select() doesn't release cob_lock in the grp_size == 1 branch, skipping the unlock label that every other exit uses. The next write lock on that object then blocks forever.
Return through the unlock label instead, with D_GOTO(unlock, rc = -DER_IO).
Steps for the author:
After all prior steps are complete: