DAOS-19212 container: check container before creating cont_track_eph_…#18627
Open
liuxuezhao wants to merge 4 commits into
Open
DAOS-19212 container: check container before creating cont_track_eph_…#18627liuxuezhao wants to merge 4 commits into
liuxuezhao wants to merge 4 commits into
Conversation
|
Ticket title is 'Aurora: performance jobs keep timing out with v2.8.0-rc1 and MDonSSD' |
Nasf-Fan
reviewed
Jul 8, 2026
…leader In ds_cont_leader_update_track_eph(), check container's existence before creating cont_track_eph_leader. Because for orphan container case the other engine possibly reports its track_eph to leader, leader should check container's valid in that case. Signed-off-by: Xuezhao Liu <xuezhao.liu@hpe.com>
Signed-off-by: Xuezhao Liu <xuezhao.liu@hpe.com>
liuxuezhao
force-pushed
the
lxz/leader_update_track_eph
branch
from
5a0ebb6 to
f9290ff
Compare
liw
reviewed
Jul 9, 2026
| /* check container's existence before creating cont_track_eph_leader */ | ||
| rc = rdb_tx_begin(svc->cs_rsvc->s_db, svc->cs_rsvc->s_term, &tx); | ||
| if (rc != 0) | ||
| D_GOTO(out_put, rc); |
Contributor
There was a problem hiding this comment.
[Question] Go to out_put will always drop rc and return 0. Is that intentional?
Contributor
Author
There was a problem hiding this comment.
ah right, looks better to fix it, I'll refresh soon, thanks
Signed-off-by: Xuezhao Liu <xuezhao.liu@hpe.com>
liw
previously approved these changes
Jul 9, 2026
Signed-off-by: Xuezhao Liu <xuezhao.liu@hpe.com>
Contributor
Author
|
will push commit 4 to fix some NLT warning for log |
Collaborator
|
Test stage Functional on EL 9 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18627/3/execution/node/1362/log |
Nasf-Fan
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…leader
In ds_cont_leader_update_track_eph(), check container's existence before creating cont_track_eph_leader. Because for orphan container case the other engine possibly reports its track_eph to leader, leader should check container's valid in that case.
Steps for the author:
After all prior steps are complete: