DAOS-19257 rebuild: discard stale tree after layout upgrade#18616
Open
wangshilong wants to merge 1 commit into
Open
DAOS-19257 rebuild: discard stale tree after layout upgrade#18616wangshilong wants to merge 1 commit into
wangshilong wants to merge 1 commit into
Conversation
During pool layout upgrade, vos_obj_layout_upgrade() only handles the in-place case where old and new OI entries share the same ilog/vos_tree. If obj_layout_diff() returns > 0, the shard is migrated to another target and the source old-layout OI entry still owns its tree exclusively. Reclaim previously called vos_obj_delete_ent() unconditionally, which removed only the OI entry and leaked the stale tree. Use obj_layout_diff() to detect whether the upgrade was in place. Keep the old behavior for shared-tree entries, and discard the underlying tree when the old entry is stale and no longer shared. Signed-off-by: Wang Shilong <shilong.wang@hpe.com>
wangshilong
added
the
clean-cherry-pick
|
Ticket title is 'Pool upgrade causes objects to occupy twice as much space after upgrade' |
kccain
approved these changes
Jul 7, 2026
liuxuezhao
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During pool layout upgrade, vos_obj_layout_upgrade() only handles the in-place case where old and new OI entries share the same ilog/vos_tree.
If obj_layout_diff() returns > 0, the shard is migrated to another target and the source old-layout OI entry still owns its tree exclusively. Reclaim previously called vos_obj_delete_ent() unconditionally, which removed only the OI entry and leaked the stale tree.
Use obj_layout_diff() to detect whether the upgrade was in place. Keep the old behavior for shared-tree entries, and discard the underlying tree when the old entry is stale and no longer shared.
Steps for the author:
After all prior steps are complete: