DAOS-18633 rebuild: throttle rebuild status logs to reduce overhead#17696
Open
wangshilong wants to merge 2 commits intomasterfrom
Open
DAOS-18633 rebuild: throttle rebuild status logs to reduce overhead#17696wangshilong wants to merge 2 commits intomasterfrom
wangshilong wants to merge 2 commits intomasterfrom
Conversation
Currently, each target dumps its rebuild progress to the log every 2 seconds unconditionally. In a large-scale scenario where a system has 100 pools rebuilding concurrently across 16 targets per rank, running for 10 hours can generate massive amounts of log data (several GBs per rank). This continuous, high-frequency logging (around 50 logs per second per xstream) causes severe I/O contention and negatively impacts overall I/O performance and ULT scheduling. There is no necessary reason to print background progress logs this frequently. This patch throttles the rebuild status log dumping from 2 seconds to 5 minutes. The final status will still be printed immediately if a rebuild completes or aborts, ensuring that we retain sufficient visibility for debugging while avoiding log storms. Signed-off-by: Wang Shilong <shilong.wang@hpe.com>
|
Errors are Unable to load ticket data |
NiuYawei
previously approved these changes
Mar 13, 2026
Collaborator
|
Test stage NLT completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17696/1/testReport/ |
liuxuezhao
reviewed
Mar 13, 2026
Signed-off-by: Wang Shilong <shilong.wang@hpe.com>
liuxuezhao
approved these changes
Mar 13, 2026
kccain
approved these changes
Mar 13, 2026
Contributor
kccain
left a comment
There was a problem hiding this comment.
any reason the leader loop doesn't use the same modulo approach as implemented in the tgt status loop?
Contributor
Author
I tried to avoid double when updating leader parts and over-optimize to avoid % operations, but forgot to update tgt status loop, but I guess this is not a big deal.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, each target dumps its rebuild progress to the log every 2 seconds unconditionally. In a large-scale scenario where a system has 100 pools rebuilding concurrently across 16 targets per rank, running for 10 hours can generate massive amounts of log data (several GBs per rank). This continuous, high-frequency logging (around 50 logs per second per xstream) causes severe I/O contention and negatively impacts overall I/O performance and ULT scheduling.
There is no necessary reason to print background progress logs this frequently. This patch throttles the rebuild status log dumping from 2 seconds to 5 minutes. The final status will still be printed immediately if a rebuild completes or aborts, ensuring that we retain sufficient visibility for debugging while avoiding log storms.
Steps for the author:
After all prior steps are complete: