Conversation
…exit code (danielmiessler#2184) `await $`cd ${workingDir} && ${command}`` escapes the interpolation into a single argv token, so a command like `bun --version` was executed as one program of that literal name. The shell answered `command not found`, which contains no `error`/`failed` keyword, so countIssues() returned 0 and `passed = errors === 0` was true. Every static_analysis grader scored 1.0 regardless of what it was asked to run — a lint or typecheck suite that could not go red. Spawn `/bin/sh -c <command>` (`cmd /c` on win32) and fail on a non-zero exit as well as on counted errors, so a tool that reports only through its exit status is graded correctly. Verified: commands `bun --version` -> 1/1 passed, `echo hello && exit 1` -> 0/1 passed, `echo all good` -> 1/1 passed. Before the change all three scored 1.0. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PuS77R8a6Lhp7jK6dnwdTh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2184.
await $\cd ${workingDir} && ${command}`escapes the interpolation into a single argv token, sobun --versionran as one program of that literal name. The shell answeredcommand not found, which contains noerror/failedkeyword, socountIssues()returned 0 andpassed = errors === 0was true.result.exitCodewas never consulted, so everystatic_analysis` grader scored 1.0 regardless of what it was asked to run.This spawns
/bin/sh -c <command>(cmd /con win32) and fails on a non-zero exit as well as on counted errors, so a tool that reports only through its exit status (tsc, most test runners) is graded correctly.Verified by driving the grader directly:
bun --versionecho hello && exit 1echo all good🤖 Generated with Claude Code
https://claude.ai/code/session_01PuS77R8a6Lhp7jK6dnwdTh