Not urgent before RC release: tests/Languages/hu/mtable.rs: add separator and row separator tests, basic with Neil doed english mtable separator and row separator tests - #699
Open
hammera wants to merge 1 commit into
Conversation
…based with english new tests Signed-off-by: Attila Hammer <hammera@pickup.hu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
@NSoiffer, this PR are not critical important, not very urgent before RC release:
I adapted your english separator and row separator matrix tests to the hungarian test suite system, fortunatelly the new tests pass right and generate good hungarian output.
This change affects only the hungarian test system with mtable.rs file, other Rust code files are unaffected.
Me purpose only to this tests are should be supported in Hungarian tests, since the delimiter rules and the new row separator rules were not included in the older English and Hungarian rule sets until Saturday if I remember right.
If you have time, please merge this change with the upstream hu branch and the upstream main branch, but this will be enough after the RC version is released, it is not a critical change, it is just an extension only of the Hungarian test system based on the new rules.
If there are any new tests that you think are worth implementing for the Hungarian tests based on the English tests that did not exist at the time of the Hungarian test generation in April when you doed the test generation in hungarian language related, I would be happy to accept your suggestion, because I do not know how many completely new tests have been added to the English test set recently since April.
The navigate.rs support is not yet covered in the Hungarian test set, maybe there are three languages that support this test, English, nb, and Russian.
If test is important your openion with future, I begin working this test adaptation with hungarian language after new stable version is come out.
Thank you for the excellent cooperation,
Attila