Open
Conversation
…ected use cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking to learn Rust a bit more and saw that
isizeis used a lot inchemistry.rs, though I don't see why it shouldn't be a standard integer type likei32.as I understand it,
isizeis primarily for pointers, ie platform dependent, which does not make sense for stuff like thelikely_chem_superscriptscoring function.side note: I find the RegEx's like
MULTIPLE_PLUS_OR_MINUS_OR_DOTvery hard to read. What do you think about having some intermediate parts to have it in smaller chunks?