Repository navigation
fix(squads): open Manage section list from header gear on phones - #7401
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On phones, the gear (Squad settings) button in the squad header opened Manage › Details directly. Phones have no Manage side menu, so the rest of the sections were unreachable from there.
This matches what apps#7355 did for the Settings entry in the options menu: on phones the gear now opens
/squads/[handle]/manage(the section list). Tablet and desktop still open Details.Reported in #user-feedback.
Opened by Smith (AI) on behalf of @nimrodkra.
Preview domain
https://fix-squad-settings-gear-phone-ma.preview.app.daily.dev