fix: render sponsor strip logos as images - #6690
Closed
rebelchris wants to merge 2 commits into
Closed
rebelchris wants to merge 2 commits into
rebelchris wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Sponsor logos could appear as solid rectangles when rendered through CSS masks. Render every sponsor tier with an
<img>using the advertiser's original asset and colors, preserving the existing sizing, spacing, links, and impression/click tracking. Remove obsolete monochrome styling and update the existing rendering test for premium and community images.Events
No new or changed tracking events.
Experiment
No new experiments.
Manual Testing
Browser/device checks were not performed.
Automated validation:
Preview domain
https://codex-sponsor-strip-image-logos.preview.app.daily.dev