fix(webapp): tolerate partial leaderboard data in users page static props - #6395
Open
tsahimatsliah wants to merge 3 commits into
Open
fix(webapp): tolerate partial leaderboard data in users page static props#6395tsahimatsliah wants to merge 3 commits into
tsahimatsliah wants to merge 3 commits into
Conversation
…rops A single flaky resolver returning partial data plus an errors array made graphql-request throw and fail the whole Vercel static export. Recover the partial payload when at least one leaderboard list is present and render the failed field as an empty list under hourly ISR; total failures (no data at all) still fail the build. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
getStaticPropson/usersno longer fails the whole Vercel build whenLEADERBOARD_QUERYreturns partial data with anerrorsarray (observed 2026-07-29:mostAchievementPoints: nullfrom a transient resolver blip killed the static export of feat(layout-v2): sidebar rail rework + Slack-style add rows #6240's preview deploy).errorsarray even whenresponse.datacarries the other fields; we now recover that partial payload when at least one leaderboard list came back, and each field falls back to[].POPULAR_HOT_TAKES_QUERY,HIGHEST_LEVEL_QUERY) keep their schema-missing-only tolerance.Tests
3 new cases in
UsersLeaderboardStaticProps.spec.ts: partial data tolerated with the failed field empty, no-data error still rejects, all-fields-errored still rejects. Suite passes (8/8), lint and strict changed-file typecheck clean.🤖 Generated with Claude Code
Preview domain
https://claude-determined-swartz-34bc29.preview.app.daily.dev