feat(shared): onboarding personas quick-start with tag pop animation#5939
Open
davidercruz wants to merge 2 commits intomainfrom
Open
feat(shared): onboarding personas quick-start with tag pop animation#5939davidercruz wants to merge 2 commits intomainfrom
davidercruz wants to merge 2 commits intomainfrom
Conversation
Adds an A/B-gated "persona" picker (Frontend, Backend, AI/ML, etc.) inside the onboarding tag step. Selecting a persona batch-follows ~10 curated tags and triggers a staggered pop animation on the corresponding tag chips so the selection feels intentional. Gated behind the new featureOnboardingPersonas GrowthBook flag. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Multi-select up to 3 personas (4th click no-ops, button looks disabled while at the cap). - Picking a persona now triggers the recommendedTags query for its tag list, with a soft-pruning rule: previous recommendation batch is evicted from the cache when a new one arrives, while curated and selected tags persist. - Extract useRecommendedTags hook so manual tag clicks and persona clicks share the same mutation, slicing, splice-at-anchor, and prune logic. Default to 2 recommended tags client-side. - Adds a spark-burst flourish (5 procedural sparks per chip) to the existing pop animation, lifted from the leaderboard crown-spark pattern. - Expose a recommend-request bus so PersonaSelector stays self-contained without prop-drilling through TagSelection. - Subtitle copy on the persona row to introduce the quick-start. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adds an A/B-gated persona picker (Frontend, Backend, AI/ML, DevOps, etc.) inside the onboarding tag step. Selecting a persona batch-follows ~10 curated tags via the existing
useTagAndSource().onFollowTagspath, and a small staggered pop animation runs across the matching tag chips so the selection reads as intentional.PersonaSelectorrenders the API-backed persona list using existingButtonchip primitives (Float/Primary+Cabbage) so visual style stays consistent with the tag pickerpersonaPopBusmodule-scoped event bus letsTagElementreact to persona clicks without prop-drilling throughTagSelectiontag-popTailwind keyframe (scale + cabbage glow with a back-ease bezier); animation auto-clears viaonAnimationEndonboardingPersonasquery) is already shipped in daily-apiEvents
select onboarding personatarget_type: 'persona',target_id: <persona id>,extra: { action: 'select' | 'switch' | 'deselect', tags_count, previous_id }Experiment
Yes — gated behind the new
onboarding_personasGrowthBook flag (featureOnboardingPersonas, defaultfalse). Slack#experimentsenrolment to be posted before merge.Important
Please do not merge the PR until the experiment enrolment is approved.
Manual Testing
On those affected packages:
Did you test the modified components media queries?
Did you test on actual mobile devices?
🤖 Generated with Claude Code
Preview domain
https://davidercruz-onboarding-personas.preview.app.daily.dev