feat(live): daily.dev show card#5937
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@claude check pr |
|
Claude finished @tomeredlich's task in 3m 4s —— View job PR Review: feat(live): daily.dev show card
SummarySolid initial implementation with a clear visual direction. A few concrete issues to address before shipping. Bug: Invalid Tailwind opacity class
<div className="absolute inset-0 bg-overlay-tertiary-black opacity-55" />
Missing feature flag
const showSyntaxLiveCard =
feedName === SharedFeedPage.MyFeed ||
feedName === SharedFeedPage.Popular ||
feedName === SharedFeedPage.Upvoted;This card is now shown to 100% of users on three high-traffic feeds with no GrowthBook gate. Per the CLAUDE.md and established pattern in this codebase, A/B experiments should use 2.9MB binary asset committed to git
Hardcoded permalink will 404
commentsPermalink: 'https://daily.dev/posts/syntax-live-mock',This points to a non-existent post. Any user clicking the card navigates to a 404. It should point to a real post URL or, if intentionally a placeholder, use Minor issues
Inline Development-context comment in source ( What's working well
|
Adds the daily.dev show feed card: a card-shaped slot with a muted self-hosted webm preview, dark overlay, centered play button, and squad/title metadata at the bottom. Inserted into MyFeed/Popular/Upvoted at index 3. - New YoutubeLiveFeedCard with poster placeholder while the webm loads. - List mode uses a tighter min-height so the card matches neighbouring posts; grid mode keeps min-h-card. - Source name uses raw salt-50 so it stays readable on the always dark video overlay in both themes. Made-with: Cursor
3b5e0d3 to
c585bc7
Compare
- Add dailyShowFeedCardFeature (default off in prod, on in dev) and gate the card via useConditionalFeature so it can be rolled out and rolled back safely. - Replace invalid opacity-55 with opacity-50 on the dark overlay (project tailwind config only allows 0/16/40/50/64/100, so the original class was a silent no-op). - Drop iteration-specific JSDoc on YoutubeLiveFeedCard. Made-with: Cursor
Summary
min-h-[17rem]so the card matches neighbouring post height; grid mode keepsmin-h-card.Test plan
Made with Cursor
Preview domain
https://daily-show-card.preview.app.daily.dev