Skip to content

chore: remove questsFeature feature flag#5923

Merged
AmarTrebinjac merged 2 commits intomainfrom
eng-1315-remove-quest-feature
Apr 28, 2026
Merged

chore: remove questsFeature feature flag#5923
AmarTrebinjac merged 2 commits intomainfrom
eng-1315-remove-quest-feature

Conversation

@AmarTrebinjac
Copy link
Copy Markdown
Contributor

@AmarTrebinjac AmarTrebinjac commented Apr 26, 2026

Summary

  • Delete the questsFeature GrowthBook feature flag definition and all useConditionalFeature checks that referenced it across 8 component/page files
  • Quest UI now renders unconditionally for logged-in users (auth checks and optOutQuestSystem user setting remain unchanged)
  • Remove dead test branches that asserted feature-off behavior; simplify remaining test mocks

Key decisions

  • Deleted the export entirely rather than changing the default to true — cleaner since there are no backend consumers
  • Kept ProtectedPage wrapper on game-center for auth protection, just removed the quest-feature fallback/404 gating
  • No backend changes needed — daily-api already serves quest data unconditionally

Closes ENG-1315


Created by Huginn 🐦‍⬛

Preview domain

https://eng-1315-remove-quest-feature.preview.app.daily.dev

The quest experiment won — remove the GrowthBook feature gate so quests
are always available to logged-in users. Delete the questsFeature
definition and all useConditionalFeature checks that referenced it.
Auth checks and the optOutQuestSystem user setting remain unchanged.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
daily-webapp Ready Ready Preview Apr 28, 2026 7:36am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
storybook Ignored Ignored Apr 28, 2026 7:36am

Request Review

@AmarTrebinjac AmarTrebinjac merged commit 74f715e into main Apr 28, 2026
13 checks passed
@AmarTrebinjac AmarTrebinjac deleted the eng-1315-remove-quest-feature branch April 28, 2026 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant