feat: experiment hiding non-Plus clickbait warning shield on feed

[nimrodkra]

Summary

Runs a GrowthBook experiment to hide the yellow/red warning ClickbaitShield badge from non-Plus users on feed cards, without touching the rest of the feature.

• Adds boolean feature feed_clickbait_shield_warning (default true) in packages/shared/src/lib/featureManagement.ts.
• In packages/shared/src/components/cards/common/ClickbaitShield.tsx, when non-Plus and the user has not fetched the smart title for this post, returns null if the flag is false.

Behavior

• Plus users: unchanged (ShieldIcon / ShieldCheckIcon).
• Non-Plus after a free try (fetchedSmartTitle = true): unchanged — still shows the green ShieldCheckIcon as proof of value.
• Non-Plus, warning state (fetchedSmartTitle = false): hidden when the flag is false; unchanged when true (default/control).
• Post detail PostClickbaitShield: unchanged.
• Feed header ToggleClickbaitShield: unchanged.

Rollout

1. Land with the flag defaulting to true (no user impact).
2. Configure a 50/50 GrowthBook experiment on non-Plus users.
3. Watch feed engagement and Plus conversion; flip default or clean up based on results.

Test plan

• Plus account: card shield renders as before (toggles original/optimized).
• Non-Plus, flag on (default): yellow/red warning shield renders as before.
• Non-Plus, flag off via GrowthBook override: no shield on cards for unfetched posts.
• Non-Plus, flag off, after using a free try on a post: green ShieldCheckIcon still renders on that card.
• Post detail pages and the feed header ToggleClickbaitShield are unaffected under both variants.

Made with Cursor

Preview domain

https://feat-clickbait-shield-warning-ex.preview.app.daily.dev

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
daily-webapp	Ready	Preview	Apr 23, 2026 0:13am

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
storybook	Ignored		Apr 23, 2026 0:13am

[nimrodkra]

@claude please reivew this pr

[claude]

Claude finished @nimrodkra's task in 1m 31s —— View job

---

PR Review

• Gather context and read changed files
• Review featureManagement.ts changes
• Review ClickbaitShield.tsx changes
• Post final review

---

Overall the change is minimal, correct, and well-scoped. One process concern and a few minor notes below.

---

packages/shared/src/lib/featureManagement.ts

✅ Clean addition. The feature key feed_clickbait_shield_warning follows existing snake_case conventions. Default true (show shield = control) is the safe starting point so there's no impact at merge time.

---

packages/shared/src/components/cards/common/ClickbaitShield.tsx

useFeature vs useConditionalFeature — ⚠️ Medium concern

The project's CLAUDE.md explicitly requires useConditionalFeature with shouldEvaluate to avoid unnecessary GrowthBook evaluations. The current code uses useFeature which evaluates the flag unconditionally on every card render — including for Plus users who will never reach the if (!isPlus) branch where the flag is consumed.

// ❌ Current — evaluates on every card, even for Plus users
const showWarningShield = useFeature(featureFeedClickbaitShieldWarning);

// ✅ Preferred — only evaluates when user is non-Plus
const { value: showWarningShield } = useConditionalFeature({
  feature: featureFeedClickbaitShieldWarning,
  shouldEvaluate: !isPlus,
});

Fix this →

---

Logic correctness — ✅

The guard condition is correct and maps exactly to the stated behavior:

if (!fetchedSmartTitle && !showWarningShield) {
  return null;
}

• Non-Plus, unfetched, flag off → null ✅
• Non-Plus, fetched (free trial used), flag off → falls through to show green ShieldCheckIcon ✅
• Plus → skips this block entirely ✅

---

ReactElement | null return type — ✅ Correctly updated.

---

Summary

One fix needed before merging: swap useFeature → useConditionalFeature with shouldEvaluate: !isPlus per project conventions. Everything else looks good.

[nimrodkra]

Addressed the review: switched to useConditionalFeature with shouldEvaluate: !isPlus per CLAUDE.md, so the flag no longer evaluates for Plus users. Pushed as ad91e8d.