-
Notifications
You must be signed in to change notification settings - Fork 290
feat: add sortable shortcuts with drag-and-drop #5247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add @dnd-kit/core, @dnd-kit/sortable, and @dnd-kit/utilities dependencies - Implement drag-and-drop sorting for shortcuts list (horizontal layout) - Implement drag-and-drop sorting for form inputs (vertical layout) - Sorting only enabled for custom links (manual mode) - Visual feedback during drag with reduced opacity - Changes persist automatically when reordering 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Chris Bongers <rebelchris@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@claude don't we have already a drag and drop sortable functionality somewhere in the app? i'm not sure introducing new packages is needed |
|
Claude finished @idoshamun's task in 1m 3s —— View job Findings on existing drag-and-drop functionality
AnalysisYou're right to question this! The codebase already has drag-and-drop functionality, but it's for a different use case: Existing drag-and-drop implementation:
This PR's drag-and-drop:
Key DifferenceThe existing code handles external drag-and-drop (files from outside the browser), while this PR needs internal sortable lists (reordering items within the UI). These are fundamentally different patterns:
Native HTML5 vs Library for Sortable ListsBuilding sortable lists with native HTML5 drag-and-drop is significantly more complex:
RecommendationThe
However, if you want to minimize dependencies, you could:
My take: Given daily.dev's startup philosophy of "move fast", using |
🤖 Generated with Claude Code
Solves:
dailydotdev/daily#747
Changes
Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
Preview domain
https://claude-issue-5246-20260106-1154.preview.app.daily.dev