feat: refactor analyze components to improve UI #5220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idoshamun
requested review from
AmarTrebinjac,
capJavert,
omBratteng and
rebelchris
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
rebelchris
reviewed
Dec 31, 2025
Contributor
rebelchris
left a comment
rebelchris
left a comment
There was a problem hiding this comment.
The animation injection is kinda meh 😂
Comment on lines
93
to
102
| <style>{` | ||
| @keyframes gentlePulse { | ||
| 0%, 100% { opacity: 1; transform: scale(1); } | ||
| 50% { opacity: 0.6; transform: scale(1.2); } | ||
| } | ||
| @keyframes fadeSlideUp { | ||
| from { opacity: 0; transform: translateY(8px); } | ||
| to { opacity: 1; transform: translateY(0); } | ||
| } | ||
| `}</style> |
Member
Author
There was a problem hiding this comment.
I already did it in another PR that got merged 🙈
What's the alternative? Adding it to a global css is not ideal as well. You prefer a module css and import?
Contributor
There was a problem hiding this comment.
Modules already cleaner or just import style.css, but this is so basic tailwind should support it no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview domain
https://analyze-cosmetics.preview.app.daily.dev