-
Notifications
You must be signed in to change notification settings - Fork 290
feat: redesign analyze page and fixed recruiter signup flow #5216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…l for clarity and improved user experience
…ion context for improved submission handling
… job analysis experience; remove AnonymousUserTable and ContentSidebar for cleaner UI
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| const onSetActiveDisplay = (display: AuthDisplay) => { | ||
| onDisplayChange?.(display); | ||
| onAuthStateUpdate?.({ isLoading: false }); | ||
| onAuthStateUpdate?.({ isLoading: false, defaultDisplay: display }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bug that prevented the inline email flow to show verification
| return false; | ||
| }; | ||
|
|
||
| const onLoginCheck = async (shouldVerify?: boolean) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved it to a bit down, due to eslint issue
| isLoading: isProfileUpdateLoading, | ||
| } = useProfileForm({ onSuccess: onProfileSuccess }); | ||
|
|
||
| const autoCompleteProfileForRecruiter = async ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We auto complete the profile not bugging recruiters with details about their profile. We'll ask them to confirm it later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file we should just do critical flow testing on deployment
| acceptedExtensions: ['pdf', 'docx'], | ||
| }; | ||
|
|
||
| const loadingMessages = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No more loading here
…e and improve clarity
rebelchris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions mainly
| isLoading: isProfileUpdateLoading, | ||
| } = useProfileForm({ onSuccess: onProfileSuccess }); | ||
|
|
||
| const autoCompleteProfileForRecruiter = async ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file we should just do critical flow testing on deployment
packages/shared/src/features/opportunity/components/analyze/AnalyzeContent.tsx
Outdated
Show resolved
Hide resolved
packages/shared/src/features/opportunity/components/analyze/AnalyzeContent.tsx
Show resolved
Hide resolved
…gationCard and ReachHeroSection components for improved data visualization in analyze page
Preview domain
https://eng-218-adjust-onboarding-to-new.preview.app.daily.dev