-
Notifications
You must be signed in to change notification settings - Fork 290
feat: add some more screening additions for more info #5215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
idoshamun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's very hard to track and review. The page is very long. I suggest refactoring to smaller components
| event_name: LogEvent.AnswerScreeningQuestion, | ||
| target_id: opportunityId, | ||
| extra: JSON.stringify({ | ||
| question_type: 'cv', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@idoshamun I added this question_type here so we can keep track of the newly added types as well
Changes
We'll just have to test it on production to be safe as this addresses current prod already.
Adds always on:
Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
Preview domain
https://feat-screening-additions.preview.app.daily.dev