Skip to content

feat: set light mode by default for recruiter #5183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rebelchris wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: set light mode by default for recruiter #5183

rebelchris wants to merge 1 commit into from

Conversation

@rebelchris
Copy link
Contributor

@rebelchris rebelchris commented Dec 18, 2025 •
edited by github-actions bot
Loading

Changes

Little bit messy, but it's due to manual overwrites and defaults.

Idea is:

  • SETTINGS_DEFAULT on API will get recruiterTheme: light
    • This means if they have settings it will be null :) and they get whatever they set.
  • If user claims opportunity on signup we assign light mode.

Events

Did you introduce any new tracking events?

Experiment

Did you introduce any new experiments?

Manual Testing

Caution

Please make sure existing components are not breaking/affected by this PR

Preview domain

https://feat-default-light.preview.app.daily.dev

@rebelchris rebelchris requested a review from a team as a code owner December 18, 2025 14:37
@vercel
Copy link

vercel bot commented Dec 18, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
daily-webapp Ready Ready Preview Dec 18, 2025 2:39pm
1 Skipped Deployment
Project Deployment Review Updated (UTC)
storybook Ignored Ignored Dec 18, 2025 2:39pm

AmarTrebinjac
AmarTrebinjac reviewed Dec 19, 2025
View reviewed changes
Copy link
Contributor

@AmarTrebinjac AmarTrebinjac left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm my bad didnt pull backnd

@AmarTrebinjac AmarTrebinjac self-requested a review December 19, 2025 08:57
AmarTrebinjac
AmarTrebinjac requested changes Dec 19, 2025
View reviewed changes
Copy link
Contributor

@AmarTrebinjac AmarTrebinjac left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clicking the logo to navigate back causes a crash:

Screen.Recording.2025-12-19.at.15.57.24.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AmarTrebinjac AmarTrebinjac AmarTrebinjac requested changes

@omBratteng omBratteng Awaiting requested review from omBratteng omBratteng is a code owner automatically assigned from dailydotdev/web-team

@capJavert capJavert Awaiting requested review from capJavert capJavert is a code owner automatically assigned from dailydotdev/web-team

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rebelchris @AmarTrebinjac